Add strict mode and remove complete promise #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If strict mode is set to false, a promise in any state (if idempotency keys match) is returned successfully to the client, otherwise the promise must be in the same state as the request.
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 69.82% 70.80% +0.97%
==========================================
Files 42 41 -1
Lines 4302 4114 -188
==========================================
- Hits 3004 2913 -91
+ Misses 1084 990 -94
+ Partials 214 211 -3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If strict mode is set to false, a promise in any state (if idempotency keys match) is returned successfully to the client, otherwise the promise must be in the same state as the request.